-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update substrate to 0.9.17 #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
force-pushed
the
alistair/update-to-0.9.17
branch
3 times, most recently
from
March 15, 2022 20:25
8cc5cb0
to
85cabcc
Compare
alistair-singh
force-pushed
the
alistair/update-to-0.9.17
branch
from
March 17, 2022 13:42
543f11a
to
8cf40db
Compare
alistair-singh
force-pushed
the
alistair/update-to-0.9.17
branch
from
March 19, 2022 10:46
8cf40db
to
b720804
Compare
Closed
vgeddes
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-198
Notable Changes
Require MaxEncodedLen per default
paritytech/substrate#10662
without_storage_info
to pallets which cannot implementMaxEncodedLen
yet. This is a non trivial change to make as we have to change code to useBoundedVec
and to check bounds.Remove Default bound for AccountId
paritytech/substrate#10403
zero
account is no longer the default as it poses potential risks around external callers using the zero account to gain privileges based onzero
account being used as default in the code base.Optional<AccountId>
in pallets.ParentIsPreset
as opposed toParentIsDefault
.CheckNonZeroSender
as a signed extension to filter outzero
accounts.Switch from StructOps to Clap for arg parsing
https://github.com/substrate-developer-hub/substrate-parachain-template/pull/101
clap
for args parsing. I have removedStructOps
to keep some symmetry with the project to make future upgrades easier.Updated Workflow Toolchains
snowbridge-test-collator
Allow unpaid execution from relay chain or relay chain executive.
https://github.com/substrate-developer-hub/substrate-parachain-template/pull/80
Unit
.E2E Tests
Currently e2e tests are failing from the parachain -> ethereum direction. This is because of an update to the BEEFY included in v0.9.17 version of polkadot. The beefy light client and relayer will need to be updated.